fix(frankenphp-symfony): add Symfony 8 to composer constraints#192
Open
dennismenken wants to merge 1 commit into
Open
fix(frankenphp-symfony): add Symfony 8 to composer constraints#192dennismenken wants to merge 1 commit into
dennismenken wants to merge 1 commit into
Conversation
PR php-runtime#185 ("Update Symfony package versions to include 8.0") updated the Symfony constraints for all other packages in this mono-repo but missed frankenphp-symfony — only the PHPUnit dev-dependency was bumped. The runtime uses stable Symfony interfaces (HttpKernelInterface, TerminableInterface, RunnerInterface, SymfonyRuntime) that are unchanged in Symfony 8.0, so no code changes are required.
|
Following |
1 similar comment
|
Following |
Author
|
Friendly ping on this one 🙂. It's been open since the end of March and there are now a couple of folks following along. The change is just the composer constraint that #185 already applied to every sibling package in the mono-repo, so it should be a quick look. Happy to rebase or address anything if needed. Is there anyone in particular I should tag for a review? |
Member
|
If I understand https://symfony.com/blog/new-in-symfony-7-4-dx-improvements-part-2#automatic-integration-of-frankenphp-worker-mode correclty FrankenPHP Runtime is since Symfony 7.4 and 8.0 part of the Symfony core and make this package so obsolete. So maybe we should better abandoned / deprecated it in favor of offical symfony integration? /cc @dunglas @Nyholm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #185 ("Update Symfony package versions to include 8.0") updated the Symfony constraints for all other packages in this mono-repo but missed
frankenphp-symfony— only the PHPUnit dev-dependency was bumped from^9.5to^10.5.58.This PR adds
|| ^8.0to the three Symfony constraints insrc/frankenphp-symfony/composer.json:symfony/dependency-injectionsymfony/http-kernelsymfony/runtimeWhy no code changes are needed
The runtime consists of two files (
Runtime.php,Runner.php) that only use stable Symfony interfaces:HttpKernelInterfaceTerminableInterfaceRunnerInterfaceSymfonyRuntimeRequestNone of these changed between Symfony 7 and 8. We have been running this package with Symfony 8.0 in production without issues.
Evidence
Comparing the diff of #185 for
frankenphp-symfonyvs other packages:frankenphp-symfony (only PHPUnit bumped):
psr-nyholm (correctly updated in same PR):